-
Notifications
You must be signed in to change notification settings - Fork 130
Add CAST AI package metadata to package list #7084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @germanilia, thanks for your interest in adding a new package to the Pulumi Registry! To keep quality in the Pulumi Registry high, we have a check-list before merging a new provider into the registry. I added the parts of the checklist you need to do to the PR description. Please confirm that your package meets those expectations and and a brief description to the PR, thanks! Is my assumption correct that the provider is maintained by a company? Could you please fill out this contact form? Thanks! https://forms.gle/ar3A5AUckZ282ZZ7A Once you've done these things, I'm going to verify the PR using this checklist:
|
CAST AI Provider v0.1.2What is CAST AI?CAST AI is a Kubernetes cost optimization platform that helps organizations reduce cloud costs by up to 50% through automated instance selection, scaling, and spot instance management. CAST AI analyzes your Kubernetes clusters and automatically optimizes them for cost efficiency without sacrificing performance or reliability. About the ProviderThe CAST AI Pulumi provider enables you to manage your CAST AI resources using infrastructure as code. This provider bridges the gap between Pulumi's infrastructure as code capabilities and CAST AI's cost optimization platform, allowing you to:
Key ResourcesThe provider includes resources for:
Use Cases
This provider helps organizations implement FinOps best practices by making cloud cost optimization an integral part of the infrastructure deployment process. |
We currently don't support c#, is this mandatory? |
Yes, we require packages in the registry to have published SDKs for all languages except Java, which is optional for the time being. |
We published all the required sdks |
Are there any other tasks we need to complete? |
@germanilia can you go through the checklist in the PR description to confirm all the pre-requisites? Once that's done I'll take it from there! |
ChecklistPlease make sure that you have:
|
@germanilia It seems that the Go and dotnet SDKs haven't been published. The links here 404 for me. I also tried installing the provider with:
We can assist you on our community slack in case you have questions about that: https://pulumi-community.slack.com |
@flostadler Thanks for the feedback, I fixed the nuget and go packages and the provider is now build in all the required configurations |
@germanilia thanks! The go SDK doesn't seem to have a tagged release for v0.1.28: https://pkg.go.dev/github.com/castai/pulumi-castai/sdk/go/castai?tab=versions |
@flostadler I fixed the tagging issue, bellow is the relevant link with the latest release |
Thanks, I’ll generate a test version of the registry with your changes and verify that everything looks correct. Monday’s a public holiday here, so it’ll take until Tuesday for me to do that. |
@germanilia It seems like your releases are broken. There's no plugin binaries published for the last few (e.g. https://github.com/castai/pulumi-castai/releases/tag/v0.1.45). Also, the Go SDK doesn't seem to get published correctly: https://pkg.go.dev/github.com/castai/pulumi-castai/sdk/go/castai?tab=versions |
@flostadler fixed the issue all the files are there for version 50 https://github.com/castai/pulumi-castai/releases/tag/v0.1.50 |
@germanilia the artifacts for darwin are missing and the others artifacts seem to be broken. The binaries in the archives have 0 bytes. Also, please fix the SDK publishing for Go like I mentioned above. We require SDKs to be published for all languages. |
@flostadler https://github.com/castai/pulumi-castai/releases/tag/v0.1.57 all the artifacts are included here. regarding go it can be found here: https://pkg.go.dev/github.com/castai/[email protected] |
@germanilia are you sure that's correct (/wrt go)? Neither do your code examples in the docs work if I do |
@flostadler I reviewed it again, the examples now work with version 71, I was able to download it and execute the examples. |
@flostadler , I am reaching out on behalf of CAST AI. Hope the PR is good to go? Please let us know if there any changes. We have customer waiting for this official release :) |
Hey @sarvesh-cast, our business development team was in contact with you, right? At least that's what I assume given that we got your details as the primary contact for this provider. |
Thanks for the update @flostadler, We have already reverted back with all details to business development team. I would like to get a quick check from you, that all of the code changes are upto pulumi standards & hope we are good to merge once we get an confirmation from your business development team ? |
@sarvesh-cast Yeah I can continue with the verification for now! Will keep you posted! |
Hey @flostadler! Are we good on code changes? |
Hey @sarvesh-cast, sadly not. It seems like you deleted your Please make sure that your submission is meeting all requirements outlined in the checklist that's in the PR description |
@flostadler Done, the missing files were added |
@germanilia Thanks, taking a look! |
@germanilia You need to release the provider after adding the missing docs. The latest release is still missing the docs: https://github.com/castai/pulumi-castai/tree/v0.1.71/docs |
@flostadler I released a new version |
@germanilia Here's the preview build of the registry with your provider: http://registry--origin-pr-7543-d964baeb.s3-website.us-west-2.amazonaws.com/registry/packages/castai/ Based on the checklist I shared here, I've noticed the following things that need to be fixed:
|
@flostadler I released a new version with the fixes you requested |
@germanilia your Go SDK publishing is broken again. This is the similar issue I pointed out here (#7084 (comment)) and it popped up again now:
Additionally, the examples you've added do not work for me because they reference non-existent input properties. For example the |
@flostadler fixed and updated the examples |
Thanks! Taking another look now |
@germanilia here's the preview build for the package at version 0.1.77: http://registry--origin-pr-7543-e129a9ae.s3-website.us-west-2.amazonaws.com/registry/packages/castai/ |
@germanilia thanks for fixing the installation instructions, they now mention the correct command for Golang. The problems related to |
@flostadler what do you mean the Golang SDK publishing being broken? you were unable to install it? |
@germanilia I just re-checked and installing is working now, maybe it was some eventual consistency problem. Please disregard that comment! So the only thing left is fixing the Golang & Dotnet examples |
I published new examples version sorry for the confusion. @flostadler |
@germanilia I published a new test version of your provider to the registry and it's looking good to me: http://registry--origin-pr-7543-256b9bf5.s3-website.us-west-2.amazonaws.com/registry/packages/castai/ From a technical perspective we're good to go. I'll follow up with our bizdev team to see if we're good to publish |
Adding Cast.ai provider. See #7084 for more details
@germanilia I've published the provider (it should be live in a couple of minutes once the deployment finishes)! See #7543 |
Checklist
Please make sure that you have:
v
(e.g.v0.1.0
). The part after the leadingv
must be valid semver 2.0.schemaFile
specified in
/community-packages/package-list.json
./docs/_index.md
and/docs/installation-configuration.md
filledout in your repo.
/docs/installation-configuration.md
links to all published SDKs./docs/index.md
shows an example of using your provider in each language.