Add cypress tests to validate docs pages #7254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your site preview for commit 3be2dba is ready! 🎉 http://registry--origin-pr-7254-3be2dba9.s3-website.us-west-2.amazonaws.com/registry. |
sean1588
changed the title
sean1588
requested review from
iwahbe,
flostadler,
danielrbradley and
mjeffryes
|
Your site preview for commit 173cb54 is ready! 🎉 http://registry--origin-pr-7254-173cb54e.s3-website.us-west-2.amazonaws.com/registry. |
sean1588
force-pushed
the
sean/add-visual-tests-registry
branch
from
173cb54 to
af5faee
Compare
|
Your site preview for commit af5faee is ready! 🎉 http://registry--origin-pr-7254-af5faee0.s3-website.us-west-2.amazonaws.com/registry. |
sean1588
force-pushed
the
sean/add-visual-tests-registry
branch
from
87ed893 to
babe1b0
Compare
|
@iwahbe - good idea! I reverted that commit locally and was able to repro. I also added an extra resource to the schema, one with the |
iwahbe
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6774
Adds a schema to represent a test provider that we can use to validate e2e from schema file to html rendered page is structured and contains all the elements as we expect.
If we want to go as far as rendering everything from overview page to clicking through navigation and then clicking through all the resources, then we could potentially do that, though not sure if that is necessary as what we really want to test is the pages generated contain everything we expect to guard against regressions. Though if we feel this is necessary we can follow on with that.
TODO: