feat: add pulumi-devin provider and hagaym1 as maintainer - #559
Conversation
|
🤖 Pulumi Neo didn't review this pull request: its author's GitHub account isn't connected to a Pulumi user in this repository's Pulumi organization. Agentic reviews run as the Pulumi user behind the author, so without that link Neo can't tell who to run as. Connect your GitHub account under Pulumi Cloud account settings, signed in as a member of the organization, and Neo will review your next pull request. |
30511b0 to
aa75979
Compare
|
Heads up that the red Run 1 (PR opened, 32111237685): The guard then diffed Run 2 (after I force-pushed the same tree to get a fresh event,
This looks like it has simply never been exercised before: Two one-line options, whichever you prefer:
Happy to open a separate PR for that if useful, though the guard itself forbids a fork PR from touching Since neither run validated the files, I checked them locally through this repo's own loader rather |
|
Correcting one thing I got wrong above: I said the fix would have to come from someone with a branch in The guard step is gated on One property worth stating explicitly, since this is a security guard rather than a convenience check: Offer stands either way, and it is equally easy for one of you to apply directly. |
|
Opened #560 with the fix, since the guard's failure here is It takes the real-history route rather than the two-dot one, so the three-dot semantics stay intact, #560 does not need to land before this one. It only changes what the check reports. |
|
Short version for whoever picks this up, since my earlier comments were long and the red check is noise:
Nothing is pending on me. Default unless you say otherwise: create the empty |
|
One update, on the caveat I flagged as the most likely blocker. "Compile and schema generation only" is
Worth noting the examples had to stop reading the Both pass here: https://github.com/hagaym1/pulumi-devin/actions/runs/32263259824 - that run's overall What has not changed: there is still no create/update/delete coverage against a real account, and I This PR itself is untouched, still the same two YAML files. |
aa75979 to
333ec03
Compare
|
Rebased onto current
Diff is unchanged, still just the two YAML files. I also re-validated both through this repo's own |
Follows up pulumiverse/.github#46, per @tmeckel's pointer to #353.
Adds the repository entry and myself as its maintainer, alongside
pulumi-unleash.typeandworkflowsmatch the other TF-bridged providers, since it is built frompulumi-tf-provider-boilerplatewith workflows generated bypulumiverse/projen-pulumi-providers.State of the provider
It already exists and works at https://github.com/hagaym1/pulumi-devin: 12 commits, 18 resources and
6 data sources bridged, all four SDKs building, and CI green except
publish_sdk, which fails onlybecause a personal repo has no registry tokens. Nothing published, no tags cut, so package identity is
still open.
Learning from #542, the three onboarding steps I raised in
pulumiverse/projen-pulumi-providers#8 are applied up front here, which is why this one did not start
out red: the ci-mgmt target points at the fork,
github-app.enabled: false, and a rootmise.tomldeclares the terraform converter. Package names are already
@pulumiverse/devin/pulumiverse_devin/Pulumiverse.Devinrather than the boilerplate's@pulumi/...defaults.Mechanics
Same as
pulumi-unleash: create the emptypulumiverse/pulumi-devinand I will push into it, doingthe
hagaym1topulumiversemodule-path rewrite as part of the move. Noimport: trueneeded onthis entry. Say the word if you would rather I transfer the existing repo instead.
On maintenance
Yes, I am signing up to maintain it.
Two ceilings worth flagging here rather than having them discovered later, both covered in more detail
in the issue:
No live test coverage, and no path to it that I can see. Every Devin API call needs an
enterprise or organization service-user token, and most resources mutate real enterprise
configuration. There is no free-tier or containerized Devin to point a throwaway stack at, so
unlike
pulumi-unleash, whereApiTokenruns against an OSS container, nothing here runs live.Coverage is compile plus schema generation, guarded by a committed schema baseline.
The upstream provider constructor is reached through a shim in my repo, not upstream's. Its
provider.Newlives ininternal/provider. I have a PR open upstream to export it(feat: add shim package re-exporting the provider constructor CognitionAI/terraform-provider-devin#3); until it lands, a local module declares a path nested
under upstream's so Go's internal-visibility check passes. It compiles today and dropping it later
is a
go.mod-only change, but it does mean the repo claims a module path in someone else'snamespace. Flagging in case that is a blocker.
Upstream is also pre-1.0 and moving quickly, so the provider tracks a
0.xline rather than promisingGo module stability on top of a
v0dependency.