Skip to content

Add Unicode fallback support with bundled OFL-licensed Noto fonts - #7

Merged
rubin110 merged 5 commits into
pumpingstationone:mainfrom
chimbly:feature/unicode-minimal
May 13, 2026
Merged

Add Unicode fallback support with bundled OFL-licensed Noto fonts#7
rubin110 merged 5 commits into
pumpingstationone:mainfrom
chimbly:feature/unicode-minimal

Conversation

@chimbly

@chimbly chimbly commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Unicode-capable rendering fallback in src/nametags/printer.py
  • keep behavior minimal and localized to printer rendering path
  • bundle official Noto fonts for out-of-box script coverage (Latin/Arabic/Hebrew/Ethiopic/CJK)
  • include upstream license texts and an assets license manifest
  • add focused Unicode rendering test ( ests/test_printer_unicode.py)

Why this approach

  • previous PR was too broad; this keeps scope tight and reviewable
  • avoids runtime dependence on host-installed fonts for core Unicode coverage
  • uses redistributable fonts with included license files

Included fonts/licenses

  • src/nametags/assets/NotoSans-Regular.ttf
  • src/nametags/assets/NotoSansArabic-Regular.ttf
  • src/nametags/assets/NotoSansHebrew-Regular.ttf
  • src/nametags/assets/NotoSansEthiopic-Regular.ttf
  • src/nametags/assets/NotoSansCJK-Regular.ttc
  • src/nametags/assets/licenses/LICENSE-NotoFonts-OFL-1.1.txt
  • src/nametags/assets/licenses/LICENSE-NotoSansCJK-OFL-1.1.txt
  • src/nametags/assets/LICENSES.md

Validation

  • python -m compileall src/nametags/printer.py tests/test_printer_unicode.py
  • $env:PYTHONPATH='src'; python -m unittest tests.test_printer_unicode -v
  • Unicode CLI render smoke test completed successfully

@willbicks
willbicks force-pushed the feature/unicode-minimal branch from 9dadc4f to a927eee Compare May 8, 2026 03:01
Wraps an over-long SimpleNamespace call so the CI ruff format check
passes. No functional change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@rubin110
rubin110 merged commit 3f50372 into pumpingstationone:main May 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants