Skip to content

Properly interpolate starfield models and use correct time windows#932

Merged
jmbhughes merged 6 commits into
mainfrom
starfield
May 8, 2026
Merged

Properly interpolate starfield models and use correct time windows#932
jmbhughes merged 6 commits into
mainfrom
starfield

Conversation

@lowderchris
Copy link
Copy Markdown
Member

Updates to starfield subtraction

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 12.76596% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.28%. Comparing base (e4af56b) to head (22279ca).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
punchbowl/level3/stellar.py 17.39% 19 Missing ⚠️
punchbowl/auto/flows/level3.py 0.00% 16 Missing ⚠️
punchbowl/util.py 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   57.39%   57.28%   -0.11%     
==========================================
  Files         125      125              
  Lines       13887    13921      +34     
==========================================
+ Hits         7970     7975       +5     
- Misses       5917     5946      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lowderchris lowderchris requested a review from jmbhughes May 7, 2026 22:46
@lowderchris lowderchris marked this pull request as ready for review May 7, 2026 22:46
@jmbhughes jmbhughes changed the title starfield subtraction updates Properly interpolate starfield models and use correct time windows May 8, 2026
@jmbhughes
Copy link
Copy Markdown
Member

I think this is good, but I'm tired and might wait to merge until morning so I can see it with fresh eyes.

@jmbhughes jmbhughes merged commit 92f1636 into main May 8, 2026
7 of 10 checks passed
@lowderchris lowderchris deleted the starfield branch May 11, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interpolate between starfield models Sort out starfield timing problems

2 participants