Skip to content

Alignment changes#973

Merged
jmbhughes merged 13 commits into
mainfrom
alignment-changes
Jun 15, 2026
Merged

Alignment changes#973
jmbhughes merged 13 commits into
mainfrom
alignment-changes

Conversation

@svank

@svank svank commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Here's a batch of miscellaneous alignment changes, including:

  • Simplify the top-level align_task
  • Use GCRS coordinates when we do find_catalog_in_image---otherwise, it's possible to have a star that right at the edge of the image in ICRS, but is just outside the image in GCRS. This changes the typical flow in that prep_star_coords has to be called before find_catalog_in_image, not after, and so I changed some input and return types to simplify that.
  • Fix for RA wrap point---the outer code that does the median of all the iterations was assuming RA would fall between 0 and 360, but the inner code didn't do any wrapping, so it could produce RA values just below 0 or just above 360. In a notebook case where an L1 alignment result was being fed back into the alignment code, astrometry chocked because the RA hint was above 360.

@svank svank requested a review from jmbhughes June 8, 2026 18:17
@svank svank self-assigned this Jun 8, 2026
@svank

svank commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

pre-commit.ci autofix

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.62791% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.30%. Comparing base (5d57cb1) to head (e375064).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
punchbowl/level1/alignment.py 11.62% 38 Missing ⚠️

❌ Your patch check has failed because the patch coverage (11.62%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (58.30%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #973   +/-   ##
=======================================
  Coverage   58.30%   58.30%           
=======================================
  Files         127      127           
  Lines       13986    13987    +1     
=======================================
+ Hits         8154     8155    +1     
  Misses       5832     5832           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmbhughes jmbhughes requested review from courtneypeck and s0larish and removed request for courtneypeck June 11, 2026 13:51
@jmbhughes

Copy link
Copy Markdown
Member

pre-commit.ci autofix

@jmbhughes

Copy link
Copy Markdown
Member

pre-commit.ci autofix

@jmbhughes jmbhughes merged commit d2b1d8b into main Jun 15, 2026
8 of 13 checks passed
@jmbhughes jmbhughes deleted the alignment-changes branch June 15, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants