Alignment changes#973
Merged
Merged
Conversation
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (11.62%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=======================================
Coverage 58.30% 58.30%
=======================================
Files 127 127
Lines 13986 13987 +1
=======================================
+ Hits 8154 8155 +1
Misses 5832 5832 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
pre-commit.ci autofix |
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
jmbhughes
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a batch of miscellaneous alignment changes, including:
find_catalog_in_image---otherwise, it's possible to have a star that right at the edge of the image in ICRS, but is just outside the image in GCRS. This changes the typical flow in thatprep_star_coordshas to be called beforefind_catalog_in_image, not after, and so I changed some input and return types to simplify that.