Skip to content

Conversation

@svank
Copy link
Contributor

@svank svank commented Jan 8, 2026

We fit lots of PSFs for PUNCH, which makes some of the visualization functions unwieldy. For ArrayPSFTransform.visualize, instead of this:
image

this PR lets you make this:
psf.visualize(fig_scale=3, edge_trim=15, patch_stride=5)
image

@svank
Copy link
Contributor Author

svank commented Jan 8, 2026

I guess I did break API by removing the old all_patches option. How much should we worry about that?

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.43%. Comparing base (0e28dbd) to head (11e1c53).

Files with missing lines Patch % Lines
regularizepsf/visualize.py 0.00% 8 Missing ⚠️
regularizepsf/psf.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   81.92%   81.43%   -0.50%     
==========================================
  Files           8        8              
  Lines         664      668       +4     
==========================================
  Hits          544      544              
- Misses        120      124       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jmbhughes jmbhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spirit of improving things and helping me not forget what things do, can you add docstrings to the visualization functions?

The CI is complaining about tests. I'm not super worried about testing this, but we could satisfy it. That's secondary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants