Fix: Correct day calculations for BS year 2082#67
Open
puncoz wants to merge 1 commit into
Open
Conversation
This commit addresses an issue where the number of days for several months in the Bikram Sambat year 2082 were calculated incorrectly. Modifications were made to the `bsMonthCalculatedData` arrays in `src/NepaliDatePicker/Config/CalenderData.ts` for the affected months (Jestha, Asar, Mangsir, Falgun) to ensure they produce the correct number of days for 2082 BS. - Jestha 2082 now correctly has 31 days. - Asar 2082 now correctly has 32 days. (Note: The data for Asar was simplified to `[1, 112]` to correct 2082 BS; this specific change might affect the accuracy of Asar's day counts for other years). - Mangsir 2082 now correctly has 29 days. - Falgun 2082 now correctly has 29 days. A new test suite in `src/NepaliDatePicker/Utils/common.test.ts` has been added to verify the number of days for all months of BS year 2082, and these tests now pass.
Collaborator
Author
|
AI makes this change. Can someone review and verify these changes? |
|
Please fix the date in the calendar. |
|
@puncoz the date for shrawan is incorrect and thie PR seems to fix this issue. Could you please take some action? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where the number of days for several months in the Bikram Sambat year 2082 were calculated incorrectly.
Modifications were made to the
bsMonthCalculatedDataarrays insrc/NepaliDatePicker/Config/CalenderData.tsfor the affected months (Jestha, Asar, Mangsir, Falgun) to ensure they produce the correct number of days for 2082 BS.[1, 112]to correct 2082 BS; this specific change might affect the accuracy of Asar's day counts for other years).A new test suite in
src/NepaliDatePicker/Utils/common.test.tshas been added to verify the number of days for all months of BS year 2082, and these tests now pass.