Skip to content

(CAT-2286) Remove puppet 7 infrastructure #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

(CAT-2286) Remove puppet 7 infrastructure #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gem_acceptance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
puppet_version:
description: "The target Puppet version."
required: false
default: "puppet7-nightly"
default: "puppet8-nightly"
type: "string"
rake_task:
description: "The name of the rake task that executes acceptance tests"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/gem_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
puppet_gem_version:
description: "Specifies the version of the Puppet gem to be installed"
required: false
default: "~> 7.0"
default: "~> 8.0"
type: "string"
rake_task:
description: "The name of the rake task that executes tests"
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
uses: reviewdog/action-shellcheck@v1
if: |
inputs.run_shellcheck &&
inputs.ruby_version == '3.2' &&
inputs.ruby_version == ${{ inputs.ruby_version.default }} &&
inputs.runs_on == 'ubuntu-latest'
with:
check_all_files_with_shebangs: "true"
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
if: |
contains(inputs.rake_task, 'coverage') &&
inputs.runs_on == 'ubuntu-latest' &&
inputs.ruby_version == '3.2' &&
inputs.ruby_version == '3.1' &&
env.CODECOV_TOKEN != ''
uses: codecov/codecov-action@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/module_acceptance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:

env:
BUNDLE_WITHOUT: release_prep
PUPPET_GEM_VERSION: '~> 7.24'
PUPPET_GEM_VERSION: '~> 8.9'
FACTER_GEM_VERSION: 'https://github.com/puppetlabs/facter#main' # why is this set?

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/module_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
if: |
inputs.run_shellcheck &&
inputs.runs_on == 'ubuntu-latest' &&
matrix.ruby_version == '3.2'
matrix.ruby_version == '3.1'
with:
check_all_files_with_shebangs: "true"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/module_release_prep.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: "setup ruby"
uses: "ruby/setup-ruby@v1"
with:
ruby-version: "3.2"
ruby-version: "3.1"
bundler-cache: "true"
bundler: 2.4.22

Expand Down