(FACT-3121) Detect Illumos (SmartOS/OmniOS) LX virtualization

[smokris]

See https://tickets.puppetlabs.com/browse/FACT-3121.

Facter uses virt-what's output which is lxc (on virt-what 1.20) or null (on virt-what 1.21+), so I added check_illumos_lx prior to retrieve_from_virt_what.

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[CLAassistant]

All committers have signed the CLA.

[smokris]

(Hmm, the test failures don't seem to be related to the changes in this PR.)

[bahamat]

Hi, I’m one of the maintainers for SmartOS. It looks to me like the behavior presented here is desirable from our perspective. (Though, I have not evaluated this code functionally, I’ll leave that to those who are more familiar).

[smokris]

Hi, @joshcooper. I saw that you merged some PRs in this repo over the last few months. Are you available to review this PR sometime soon?

[mhashizume]

Closing and reopening to retrigger tests

[mhashizume]

Hi @smokris , thank you for your contribution and sorry for the delay.

Would you be able to rebase you PR and resolve the conflict?

Thank yoU!

[smokris]

@mhashizume, yes, I pushed d959b40 a few minutes ago, in which I've rebased onto current main, and squashed the 2 commits into 1 (since there's no need to preserve the name-change commit). Investigating test failures now…

[smokris]

GitHub CI is running the tests in a different random order each time, and the tests were failing intermittently depending on the order they ran. For example, bundle exec rspec --order random:47312 consistently failed, while bundle exec rspec --order random:36802 consistently passed.

If I understand correctly, the problem was that, if the test calls a resolver that isn't mocked, then the resolver will execute on the current system and cache its results (rather than merely returning the mocked results without caching), and the cached results break subsequent tests (even if mocked).

I pushed 430d549, which I think adds all the necessary mocks to enable the tests to pass regardless of order.

[mhashizume]

Thank you for your contribution @smokris !

[mhashizume]

Closing and reopening to pick up new check