(maint) Limit scope and timing of selection #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selection is done by the caller as a part of the callbacks registered via the tab component and tabs. The timing of this callback depeends on when the tabs are rendered. This applies a bottleneck to ensure that the tab selection is honored when specified, by delaying selection until after the render loop for the current tabs are rendered. i# Changes to be committed:
jonathannewman
force-pushed
the
maint/main/avoid-selecting-when-no-specification
branch
from
53ef06f to
be525cf
Compare
jonathannewman
changed the title
beechtom
approved these changes
Jun 17, 2025
jonathannewman
deleted the
maint/main/avoid-selecting-when-no-specification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selection is done by the caller as a part of the callbacks registered
via the tab component and tabs. The timing of this callback depeends
on when the tabs are rendered. This applies a bottleneck to ensure
that the tab selection is honored when specified, by delaying selection
until after the render loop for the current tabs are rendered.