Skip to content

fix: do not treat clientcert as a legacy network fact in puppet lookup #9579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raman1236 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

fix: do not treat clientcert as a legacy network fact in puppet lookup #9579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/puppet/application/lookup.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
class Puppet::Application::Lookup < Puppet::Application
RUN_HELP = _("Run 'puppet lookup --help' for more details").freeze
DEEP_MERGE_OPTIONS = '--knock-out-prefix, --sort-merged-arrays, and --merge-hash-arrays'
TRUSTED_INFORMATION_FACTS = %w[hostname domain fqdn clientcert].freeze
TRUSTED_INFORMATION_FACTS = %w[hostname domain fqdn].freeze

run_mode :server

Expand Down
14 changes: 13 additions & 1 deletion spec/unit/application/lookup_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ def run_lookup(lookup)

expect {
lookup.run_command
}.to raise_error(/When overriding any of the hostname,domain,fqdn,clientcert facts with #{file_path} given via the --facts flag, they must all be overridden./)
}.to raise_error(/When overriding any of the hostname,domain,fqdn facts with #{file_path} given via the --facts flag, they must all be overridden./)
end

it 'does not fail when all trusted information facts are provided via --facts file' do
Expand All @@ -668,6 +668,18 @@ def run_lookup(lookup)
fqdn: some.fqdn.com
hostname: some.hostname
domain: some.domain
CONTENT
lookup.options[:fact_file] = file_path

expect {
lookup.run_command
}.to exit_with(0)
.and output(/This is in facts hash/).to_stdout
end

it 'does not fail when clientcert is provided without other trusted facts' do
file_path = file_containing('facts.yaml', <<~CONTENT)
---
clientcert: some.clientcert
CONTENT
lookup.options[:fact_file] = file_path
Expand Down