Simplify mod::php unit tests #2482
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Oct 11, 2023
spec/classes/mod/php_spec.rb
Outdated
| facts[:os]['name'] == 'Rocky' || facts[:os]['name'] == 'AlmaLinux')) | ||
|
|
||
| describe 'OS independent tests' do | ||
| describe 'OS independent tests', unless: ['Debian', 'RedHat'].include?(facts[:os]['family']) || (facts[:os]['release']['major'].to_i >= 15 && facts[:os]['name'] == 'SLES') do |
Collaborator
There was a problem hiding this comment.
This makes changes. Previously it ran on EL7 but now that's skipped altogether.
ekohl
reviewed
Oct 11, 2023
| describe 'OS independent tests' do | ||
| skip_os = ['Debian', 'RedHat'] | ||
| describe 'OS independent tests', | ||
| unless: skip_os.include?(facts[:os]['family'] && facts[:os]['release']['major'].to_i > 7) || (facts[:os]['release']['major'].to_i >= 15 && facts[:os]['name'] == 'SLES') do |
Collaborator
There was a problem hiding this comment.
That's an interesting hack. Technically you're right that Debian > 7 should be skipped. Though I always find >= 8 easier to read than > 7. Is that just me?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)