Skip to content

Avoid corrective changes when downloading packages via archive #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid corrective changes when downloading packages via archive #674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions manifests/packages.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@
# Defaults to 32767
# @param archive_checksum_type
# Defaults to 'sha256'
# @param archive_cleanup
# Whether downloaded archives should be deleted after extracting. Cleaning files will save some space,
# but might lead to frequent corrective changes (service restarts)
# Default: false
# @param tmp_directory
# Directory to use when downloading archives for install.
# Default to /var/tmp/puppetlabs-kubernetes
Expand Down Expand Up @@ -154,6 +158,7 @@
Boolean $pin_packages = $kubernetes::pin_packages,
Integer $package_pin_priority = 32767,
String $archive_checksum_type = 'sha256',
Boolean $archive_cleanup = false,
String $tmp_directory = $kubernetes::tmp_directory,
Optional[String] $http_proxy = $kubernetes::http_proxy,
Optional[String] $https_proxy = $kubernetes::https_proxy,
Expand Down Expand Up @@ -422,7 +427,7 @@
checksum => $runc_source_checksum,
checksum_verify => $runc_source_checksum_verify,
extract => false,
cleanup => false,
cleanup => $archive_cleanup,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this archive resource has extract => false, maybe this isn't needed?

creates => $runc_source_creates,
}
-> file { '/usr/bin/runc':
Expand Down Expand Up @@ -469,7 +474,7 @@
extract => true,
extract_command => 'tar xfz %s --strip-components=1 -C /usr/bin/',
extract_path => '/',
cleanup => true,
cleanup => $archive_cleanup,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$containerd_archive_cleanup ?

creates => $containerd_archive_creates,
notify => Service['containerd'],
require => File[$tmp_directory],
Expand All @@ -494,7 +499,7 @@
extract => true,
extract_command => 'tar xfz %s --strip-components=1 -C /usr/local/bin/',
extract_path => '/usr/local/bin',
cleanup => true,
cleanup => $archive_cleanup,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$etc_archive_checksum_cleanup ?

creates => $etcd_archive_creates,
notify => Service['etcd'],
require => File[$tmp_directory],
Expand Down