Skip to content

added helper method in mysql provider to pick mysql or mariadb binary…#1689

Open
rtuk wants to merge 1 commit into
puppetlabs:mainfrom
Team-MostWanted:feature/mariadb-11-support
Open

added helper method in mysql provider to pick mysql or mariadb binary…#1689
rtuk wants to merge 1 commit into
puppetlabs:mainfrom
Team-MostWanted:feature/mariadb-11-support

Conversation

@rtuk

@rtuk rtuk commented Sep 25, 2025

Copy link
Copy Markdown

added helper method in mysql provider to pick mysql or mariadb binary variant based on version

changed commands to use the new helper method

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.
#1685
#1676
#1672

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

… variant based on version

changed commands to use the new helper method
@rtuk rtuk requested review from a team, alexjfisher and bastelfreak as code owners September 25, 2025 09:26
@CLAassistant

CLAassistant commented Sep 25, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@j-koehler

Copy link
Copy Markdown

Wow, looks like Perforce is not interested in any community work anymore and putting the whole Puppet eco system behind closed doors. Their "official" puppetlabs-mysql is broken for any supported MariaDB release, this PR (presumably) fixes this and is still "open" for months. Wow.

@SimonHoenscheid

Copy link
Copy Markdown

@jst-cyr can perforce please fix the errors with MariaDB 11.x? That is laying around for quite some time and needs a release afterwards. See also the linked issues.

@jst-cyr

jst-cyr commented Jun 10, 2026

Copy link
Copy Markdown
Member

Thank you for flagging this to me @SimonHoenscheid . I'm going to add this particular PR into my list to review with engineering, but it looks like there is a general need for some mysql updates here which I'll also need to review.

@SimonHoenscheid

Copy link
Copy Markdown

@jst-cyr I am not exactly sure this PR will solve the problem. But the issue linked needs to be solved.

Thanks for having a look on this.

@cruelsmith

Copy link
Copy Markdown
Contributor

JFYI: A simple remove of the hard coded commands inside the child provider files did also fixed the issue, since #1645 already added the handling in the parent provider file.

Requried cleanup bc7fc80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants