Add purge and recurse options to the include directory creation when … - #1695
Open
bschonec wants to merge 1 commit into
Open
Add purge and recurse options to the include directory creation when …#1695bschonec wants to merge 1 commit into
bschonec wants to merge 1 commit into
Conversation
bschonec
requested review from
a team,
alexjfisher and
bastelfreak
as code owners
November 12, 2025 12:16
bschonec
force-pushed
the
add_purge_recurse_to_include_directory_when_mariadb
branch
2 times, most recently
from
November 12, 2025 12:49
82cdf26 to
8755f90
Compare
bschonec
marked this pull request as draft
January 21, 2026 12:07
bschonec
force-pushed
the
add_purge_recurse_to_include_directory_when_mariadb
branch
from
January 21, 2026 12:29
90d9095 to
885679f
Compare
bschonec
marked this pull request as ready for review
January 21, 2026 12:30
Author
|
@bastelfreak @alexjfisher do you have the ability to approve for a merge? |
bschonec
force-pushed
the
add_purge_recurse_to_include_directory_when_mariadb
branch
from
March 5, 2026 18:31
04bdcb0 to
6f26e8a
Compare
Member
|
I'm really sorry for the delay in any responses on this PR. I've been going through older PRs and found this one. Is this still an issue in your environment? |
Author
|
@jst-cyr , yep. I'm using my own fork/branch in the interim. |
jst-cyr
force-pushed
the
add_purge_recurse_to_include_directory_when_mariadb
branch
from
August 17, 2026 12:40
6f26e8a to
a6861e6
Compare
Member
|
Hi @bschonec , I rebased the PR here and re-ran CI. Looks like the spec tests found some syntax feedback: https://github.com/bschonec/puppetlabs-mysql/actions/runs/32031030781/job/95391060398 |
bschonec
force-pushed
the
add_purge_recurse_to_include_directory_when_mariadb
branch
from
August 17, 2026 12:52
a6861e6 to
fcf8e7f
Compare
Author
|
@jst-cyr hopefully fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…MariaDB package.
Summary
On MariaDB package, the purge/recurse options weren't set for the include_dir directory.