Respect ensure when managing xtrabackup backup package#1716
Open
milad-zanganeh wants to merge 3 commits into
Open
Respect ensure when managing xtrabackup backup package#1716milad-zanganeh wants to merge 3 commits into
milad-zanganeh wants to merge 3 commits into
Conversation
ec182a5 to
408b56a
Compare
|
|
408b56a to
51fc626
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
mysql::backup::xtrabackupso that the backup method package and backup directory are removed when the class is declared withensure => absent.Additional Context
stdlib::ensure_packages($backupmethod_package)was called without an options hash, defaulting the package toensure => presentregardless of the class$ensureparameter.mysql::server::backup(withbackupmethod => 'xtrabackup') andensure => absent, runpuppet apply, and observe that the backup method package remains installed and still manages the backup directory.$ensureparameter (Enum['present', 'absent']) used for the other backup resources. Passing it through tostdlib::ensure_packagesand file makes the package and directory lifecycle consistent with the rest of the backup resources without introducing a new parameter.