Skip to content

(MODULES-8700) Autorequire the service in postgresql_psql #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/puppet/type/postgresql_psql.rb
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ def matches(value)
newvalues(:true, :false)
end

autorequire(:class) { ['Postgresql::Server::Service'] }
autorequire(:anchor) { ['postgresql::server::service::begin'] }
autorequire(:service) { ['postgresqld'] }

def should_run_sql(refreshing = false)
onlyif_param = @parameters[:onlyif]
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/defines/server/database_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
end

it { is_expected.to contain_postgresql__server__database('test') }
it { is_expected.to contain_postgresql_psql('CREATE DATABASE "test"') }
it { is_expected.to contain_postgresql_psql('CREATE DATABASE "test"').that_requires('Service[postgresqld]') }

context "with comment set to 'test comment'" do
let(:params) { { comment: 'test comment' } }
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/defines/server/grant_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class {'postgresql::server':}
it { is_expected.to contain_postgresql__server__role('test') }
it do
is_expected.to contain_postgresql_psql('grant:test') \
.that_requires(['Class[postgresql::server::service]', 'Postgresql::Server::Role[test]'])
.that_requires(['Service[postgresqld]', 'Postgresql::Server::Role[test]'])
end
end

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/defines/server/reassign_owned_by_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@ class {'postgresql::server':}
is_expected.to contain_postgresql_psql('reassign_owned_by:test:REASSIGN OWNED BY "test_old_role" TO "test_new_role"')
.with_command('REASSIGN OWNED BY "test_old_role" TO "test_new_role"')
.with_onlyif(%r{SELECT tablename FROM pg_catalog.pg_tables WHERE\s*schemaname NOT IN \('pg_catalog', 'information_schema'\) AND\s*tableowner = 'test_old_role'.*}m)
.that_requires('Class[Postgresql::Server::Service]')
.that_requires('Service[postgresqld]')
}
end
4 changes: 2 additions & 2 deletions spec/unit/defines/server/role_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
.with_unless("SELECT 1 FROM pg_roles WHERE rolname = 'test'")
.with_port(5432)
.with_connect_settings('PGHOST' => 'postgres-db-server', 'DBVERSION' => '9.1', 'PGUSER' => 'login-user', 'PGPASSWORD' => 'login-pass')
.that_requires('Class[postgresql::server::service]')
.that_requires('Service[postgresqld]')
end
it 'has alter role for "test" user with password as ****' do
is_expected.to contain_postgresql_psql('ALTER ROLE test ENCRYPTED PASSWORD ****')
Expand Down Expand Up @@ -142,7 +142,7 @@
end

it 'has drop role for "test" user if ensure absent' do
is_expected.to contain_postgresql_psql('DROP ROLE "test"').that_requires('Class[postgresql::server::service]')
is_expected.to contain_postgresql_psql('DROP ROLE "test"').that_requires('Service[postgresqld]')
end
end

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/defines/server/tablespace_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

it { is_expected.to contain_file('/srv/data/foo').with_ensure('directory') }
it { is_expected.to contain_postgresql__server__tablespace('test') }
it { is_expected.to contain_postgresql_psql('CREATE TABLESPACE "test"').that_requires('Class[postgresql::server::service]') }
it { is_expected.to contain_postgresql_psql('CREATE TABLESPACE "test"').that_requires('Service[postgresqld]') }

context 'with different owner' do
let :params do
Expand Down