Skip to content

(#1532) Replace ParserError with Puppet::Error #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

(#1532) Replace ParserError with Puppet::Error #1538

wants to merge 1 commit into from

Conversation

bastelfreak
Copy link
Collaborator

@bastelfreak bastelfreak commented Oct 19, 2023 •
edited
Loading

I'm not sure how we ended up with ParserError in the provider. This exception doesn't exist in Ruby. Puppet ships ther own exception, Puppet::Error. It probably makes sense to raise that instead.

Fixes 179472b

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@bastelfreak bastelfreak mentioned this pull request Oct 19, 2023
Closed
@bastelfreak bastelfreak force-pushed the error branch 2 times, most recently from 5b1d7ae to a2bc4b0 Compare October 19, 2023 13:03
@ekohl ekohl linked an issue Oct 19, 2023 that may be closed by this pull request
Postgresql::Server::Config_entry uninitialized constant ParserError #1532
Closed
@ekohl
Copy link
Collaborator

ekohl commented Oct 19, 2023

Fixes 179472b, so part of 10.0.0.

@bastelfreak bastelfreak force-pushed the error branch 3 times, most recently from 29f4418 to cf0d538 Compare October 19, 2023 14:09
@jlindquist-godaddy
Copy link

LGTM, thanks!

@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
3338350 
I'm not sure how we ended up with ParserError in the provider. This
exception doesn't exist in Ruby. Puppet ships ther own exception,
Puppet::Error. It probably makes sense to raise that instead.

Fixes 179472b
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Oct 19, 2023
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
1bfbee5 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
@bastelfreak bastelfreak mentioned this pull request Oct 19, 2023
Merged
5 tasks
@bastelfreak
Copy link
Collaborator Author

I implemented a more working and more detailed solution in #1540, thanks to @ekohl <3

bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Oct 19, 2023
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
127f436 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Oct 19, 2023
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
7bc3141 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Oct 19, 2023
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
481eb3f 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Oct 26, 2023
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
8638fd9 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Nov 13, 2023
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
1680e14 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Nov 13, 2023
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
fdf8f8c 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Nov 27, 2023
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
5b71fd7 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Jan 17, 2024
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
a50406b 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Apr 8, 2024
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
e02387e 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Apr 10, 2024
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
dea0041 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
bastelfreak added a commit to bastelfreak/puppetlabs-postgresql that referenced this pull request Apr 10, 2024
@bastelfreak
(puppetlabs#1532) Replace ParserError with Puppet::Error
b797bbd 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
vaol pushed a commit to vaol/puppetlabs-postgresql that referenced this pull request Oct 13, 2024
@bastelfreak @vaol
(puppetlabs#1532) Replace ParserError with Puppet::Error
089c6a7 
I'm not sure how we ended up with ParserError in the
provider. This exception doesn't exist in Ruby.
Puppet ships ther own exception, Puppet::Error. It
probably makes sense to raise that instead.

Fixes 179472b

Alternative implementation for puppetlabs#1538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner

@deric deric Awaiting requested review from deric deric is a code owner

@SimonHoenscheid SimonHoenscheid Awaiting requested review from SimonHoenscheid SimonHoenscheid is a code owner

@smortex smortex Awaiting requested review from smortex smortex is a code owner

Assignees
No one assigned
Labels
community maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgresql::Server::Config_entry uninitialized constant ParserError
4 participants
@bastelfreak @ekohl @jlindquist-godaddy @ia-content