fix: Fixed typo ParserError #1570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dploeger
requested review from
alexjfisher,
bastelfreak,
deric,
ekohl,
SimonHoenscheid,
smortex and
a team
as code owners
|
similar to #1540 |
alexjfisher
previously approved these changes
Jan 17, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
alexjfisher
dismissed
their stale review
Maybe better to progress #1540 and close this PR?
|
We merged #1540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After running into a duplicate config entry I found that this line uses the wrong class to notify about the parser error
Additional Context
Reproduce: Put a config entry twice into the postgresql conf and try to manage it using this module. => Leads to:
I didn't run the tests as I just wanted to correct this simple thing. I can do a full checkout and test them if you'd like.
Checklist
puppet apply)