(CAT-2385) Puppetcore update - #1646
Merged
Merged
Conversation
shubhamshinde360
force-pushed
the
CAT-2385
branch
2 times, most recently
from
September 29, 2025 14:38
940e023 to
d8dd30d
Compare
Collaborator
|
@shubhamshinde360 can you please rebase? The unit tests were fixed in #1647 |
bastelfreak
reviewed
Sep 30, 2025
bastelfreak
reviewed
Sep 30, 2025
bastelfreak
reviewed
Sep 30, 2025
bastelfreak
reviewed
Sep 30, 2025
shubhamshinde360
force-pushed
the
CAT-2385
branch
from
September 30, 2025 12:15
d8dd30d to
eba9dd2
Compare
shubhamshinde360
force-pushed
the
CAT-2385
branch
3 times, most recently
from
December 11, 2025 17:40
7d5e4dd to
9b19231
Compare
- Removes redhat-7 testing in python_spec. - Replaces redhat-7 with redhat-8 in default_privileges_spec. Note that since redhat-8 has a newer version of postgresql, so default privileges should compile successfully for it.
shubhamshinde360
force-pushed
the
CAT-2385
branch
from
January 8, 2026 13:35
9b19231 to
89498bf
Compare
Contributor
Author
|
SLES failures are unrelated and are being worked upon in https://perforce.atlassian.net/browse/CAT-2511 EL-7 based platforms (CentOS-7, OracleLinux-7, Scientific-7) have had their images deprecated from GCP and will require efforts for fixing it. They are in the discussion for deprecation so we'll hold off on them till a decision regarding deprecation is made. |
shubhamshinde360
marked this pull request as ready for review
January 9, 2026 06:26
shubhamshinde360
requested review from
a team,
SimonHoenscheid,
alexjfisher,
deric,
ekohl and
smortex
as code owners
January 9, 2026 06:26
amitkarsale
approved these changes
Jan 9, 2026
imaqsood
added a commit
that referenced
this pull request
Jul 7, 2026
10.6.2 (PR #1646, "CAT-2385 Puppetcore update") bumped .rubocop.yml TargetRubyVersion to 3.1, so `rubocop -A` rewrote hash literals to Ruby 3.1 shorthand (`salt:` instead of `salt: salt`) in three custom functions/providers. That shorthand is a hard syntax error on Ruby < 3.1, and Puppet 7 ships Ruby 2.7 -- so any Puppet 7 catalog using postgresql::postgresql_password, postgresql_conf or postgresql_replication_slot failed to compile with "syntax error, unexpected ','" (issue #1685). Fix the Ruby side so existing Puppet 7 installations keep working: - .rubocop.yml: TargetRubyVersion back to '2.6' so autocorrect can't reintroduce the shorthand. - Revert the Ruby 3.1 shorthand hash syntax in the three lib files (keeping the unrelated postgresql_conf entry_regex bugfix from #1657). - Revert the same shorthand autocorrection in four spec files so they parse under the 2.6 target. Verified with `pdk validate`, the full unit suite (685 examples, 0 failures), and Litmus end-to-end applies on both Puppet 7.34/Ruby 2.7 and Puppet 8.10/Ruby 3.2 (install, idempotency, and a SCRAM-SHA-256 password hash stored in the live database). Fixes #1685 Co-Authored-By: Claude <noreply@anthropic.com>
ikonia
pushed a commit
to ikonia/puppetlabs-postgresql
that referenced
this pull request
Aug 13, 2026
(CAT-2385) Puppetcore update
ikonia
pushed a commit
to ikonia/puppetlabs-postgresql
that referenced
this pull request
Aug 13, 2026
10.6.2 (PR puppetlabs#1646, "CAT-2385 Puppetcore update") bumped .rubocop.yml TargetRubyVersion to 3.1, so `rubocop -A` rewrote hash literals to Ruby 3.1 shorthand (`salt:` instead of `salt: salt`) in three custom functions/providers. That shorthand is a hard syntax error on Ruby < 3.1, and Puppet 7 ships Ruby 2.7 -- so any Puppet 7 catalog using postgresql::postgresql_password, postgresql_conf or postgresql_replication_slot failed to compile with "syntax error, unexpected ','" (issue puppetlabs#1685). Fix the Ruby side so existing Puppet 7 installations keep working: - .rubocop.yml: TargetRubyVersion back to '2.6' so autocorrect can't reintroduce the shorthand. - Revert the Ruby 3.1 shorthand hash syntax in the three lib files (keeping the unrelated postgresql_conf entry_regex bugfix from puppetlabs#1657). - Revert the same shorthand autocorrection in four spec files so they parse under the 2.6 target. Verified with `pdk validate`, the full unit suite (685 examples, 0 failures), and Litmus end-to-end applies on both Puppet 7.34/Ruby 2.7 and Puppet 8.10/Ruby 3.2 (install, idempotency, and a SCRAM-SHA-256 password hash stored in the live database). Fixes puppetlabs#1685 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Puppetcore update
Checklist
puppet apply)