(CAT-2763) Rename gem: puppet-syntax -> puppetlabs-syntax - #4
Merged
Conversation
Completes Gate 2 (gemspec identity) and Gate 3 (constant tree + load-path) of the three-gate rename model: spec.name, lib/, spec/, the PuppetSyntax -> PuppetlabsSyntax constant tree, and every require path now say puppetlabs-syntax. Version bumped to 7.2.1 per ADR-0004 (mirrors Vox upstream, sits above the yanked public 7.2.0 slot). Gate 1 (puppet core runtime pin) was already done in a prior commit. 44/44 specs green after the rename. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Ran `rubocop --auto-gen-config --no-auto-gen-timestamp` after the puppetlabs-syntax rename so every Exclude: path matches the new lib/puppetlabs-syntax/... and spec/puppetlabs-syntax/... locations. Stale exclude paths pointing at the old puppet-syntax/ layout would silently stop applying otherwise. `rubocop` reports no offenses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- Add the ADR-0001-mandated fork banner identifying this as the Perforce-maintained puppetlabs fork of voxpupuli/puppet-syntax. - Rename all PuppetSyntax/puppet-syntax prose and code samples to PuppetlabsSyntax/puppetlabs-syntax. - Repoint badges at puppetlabs/puppetlabs-syntax; fix the Test badge, which pointed at a workflow file (test.yml) that doesn't exist in this repo's .github/workflows/ (the real CI workflow is ci.yml). - Correct a stale "OpenVox >= 8.0" version-support claim to "Puppet >= 8.0, < 10" - this fork's gemspec already pins puppet as its core (Gate 1), not openvox. CHANGELOG.md/HISTORY.md intentionally left untouched - historically accurate to voxpupuli/puppet-syntax. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
gavindidrichsen
added
maintenance
backwards-incompatible
and removed
maintenance
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the local, non-publishing part of the CAT-2763 fork-and-rename: this gem is now genuinely
puppetlabs-syntaxend-to-end, not just relabeled at the repo/gemspec-metadata level.puppet-syntax.gemspec->puppetlabs-syntax.gemspec(spec.name, version bumped to7.2.1per ADR-0004),lib//spec/moved topuppetlabs-syntax/...,PuppetSyntax->PuppetlabsSyntaxconstant tree, everyrequirepath updated. Gate 1 (puppet core runtime pin) was already done in a prior commit..rubocop_todo.ymlregenerated viarubocop --auto-gen-configso itsExclude:paths match the new file layout.README.mdupdated: added the required fork banner, renamed all naming, repointed badges atpuppetlabs/puppetlabs-syntax(and fixed a Test badge pointing at a nonexistenttest.ymlworkflow), and corrected a stale "OpenVox >= 8.0" claim to "Puppet >= 8.0, < 10" to match this fork's actual core pin.CHANGELOG.md/HISTORY.mdintentionally untouched — historically accurate tovoxpupuli/puppet-syntax.This is a breaking rename for downstream consumers:
require 'puppet-syntax/tasks/puppet-syntax'/PuppetSyntaxbecomesrequire 'puppetlabs-syntax/tasks/puppetlabs-syntax'/PuppetlabsSyntax.No publish (no
gem push, no rubygems/GitHub Packages release) is part of this PR — that remains a separately gated step.Test plan
bundle exec rake spec— 44 examples, 0 failuresbundle exec rubocop— no offensesgit grep -n 'PuppetSyntax\|puppet-syntax' -- lib spec Rakefile '*.gemspec'— zero hitsGemfile.lockregenerates showingpuppetlabs-syntax (7.2.1)🤖 Generated with Claude Code