(maint) Add note to update the pdk-templates lint whenever it is changed here #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge here In order to ensure that our lint testing remains in step we must keep these two files in sync with eachother: - https://github.com/puppetlabs/puppetlabs_spec_helper/blob/main/lib/puppetlabs_spec_helper/rake_tasks.rb#L124 - https://github.com/puppetlabs/pdk-templates/blob/d9e6478ff7730a8ce072ce0c1d36a9b79f05ba2c/config_defaults.yml#L69
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
=======================================
Coverage 43.95% 43.95%
=======================================
Files 10 10
Lines 662 662
=======================================
Hits 291 291
Misses 371 371 ☔ View full report in Codecov by Sentry. |
gavindidrichsen
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ensure that our lint testing remains in step we must keep these two files in sync with eachother:
Checklist