Skip to content

Conversation

@bastelfreak
Copy link
Collaborator

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@bastelfreak bastelfreak self-assigned this Feb 22, 2025
@bastelfreak bastelfreak requested a review from a team as a code owner February 22, 2025 22:05
@bastelfreak
Copy link
Collaborator Author

The only actual change is that rspec-github drops ruby 3.0 and older support. With above patch we allow all versions of it.

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The lower bound is staying the same so this is fine to me

@david22swan david22swan merged commit c227a0d into puppetlabs:main Feb 25, 2025
7 checks passed
@bastelfreak bastelfreak deleted the github branch February 25, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants