-
Notifications
You must be signed in to change notification settings - Fork 1
Use TOML configuration file #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request migrates the webring configuration from CLI arguments to a dedicated TOML configuration file. The changes include adding a new configuration file (webring.toml), updating tests and the main application to load configuration from TOML, and updating documentation and Cargo.toml to reflect the new configuration approach.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| webring.toml | Introduces the new TOML configuration with various sections. |
| src/routes.rs | Updates test setup to build a configuration using TOML and indoc. |
| src/main.rs | Removes CLI options in favor of loading configuration from TOML. |
| src/discord.rs | Adds Deserialize support to enable configuration deserialization. |
| doc/Configuration.md | Adds documentation for the new TOML configuration format. |
| Cargo.toml | Updates dependencies and metadata to support the new configuration. |
Comments suppressed due to low confidence (2)
webring.toml:16
- The use of '???' as a member key is unclear and could lead to confusion; consider renaming it to a more descriptive identifier.
"???" = { url = "ws://refuse-the-r.ing", check-level = "none" }
src/routes.rs:495
- The ambiguous member key '???' used in the test configuration may cause confusion; consider using a clear, descriptive key name.
"???" = {{ url = "ws://refuse-the-r.ing", check-level = "none" }}
This commit disables live reloading of the member list, since that will need to be adapted to work with the new configuration file. That will need to be fixed in a future commit.
Uses a TOML configuration file instead of command-line arguments for webring configuration. Closes #19.
Uses a TOML configuration file instead of command-line arguments for webring configuration.
Closes #19.
To do