Skip to content

Conversation

@kdkasad
Copy link
Collaborator

@kdkasad kdkasad commented May 24, 2025

Uses a TOML configuration file instead of command-line arguments for webring configuration.

Closes #19.

To do

  • Load configuration from TOML file
  • Write unit tests
  • Move member list into configuration file
    • Load members from configuration file
    • Adjust file reloading to work with the changes
  • Write documentation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request migrates the webring configuration from CLI arguments to a dedicated TOML configuration file. The changes include adding a new configuration file (webring.toml), updating tests and the main application to load configuration from TOML, and updating documentation and Cargo.toml to reflect the new configuration approach.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
webring.toml Introduces the new TOML configuration with various sections.
src/routes.rs Updates test setup to build a configuration using TOML and indoc.
src/main.rs Removes CLI options in favor of loading configuration from TOML.
src/discord.rs Adds Deserialize support to enable configuration deserialization.
doc/Configuration.md Adds documentation for the new TOML configuration format.
Cargo.toml Updates dependencies and metadata to support the new configuration.
Comments suppressed due to low confidence (2)

webring.toml:16

  • The use of '???' as a member key is unclear and could lead to confusion; consider renaming it to a more descriptive identifier.
"???" = { url = "ws://refuse-the-r.ing", check-level = "none" }

src/routes.rs:495

  • The ambiguous member key '???' used in the test configuration may cause confusion; consider using a clear, descriptive key name.
"???" = {{ url = "ws://refuse-the-r.ing", check-level = "none" }}

@kdkasad kdkasad marked this pull request as ready for review May 25, 2025 09:07
@kdkasad kdkasad requested a review from Xendergo May 25, 2025 09:07
kdkasad added 6 commits May 26, 2025 02:19
This commit disables live reloading of the member list, since that will
need to be adapted to work with the new configuration file. That will
need to be fixed in a future commit.
@kdkasad kdkasad merged commit e93c5ed into master May 26, 2025
10 of 12 checks passed
@kdkasad kdkasad deleted the toml branch May 26, 2025 21:58
kdkasad added a commit that referenced this pull request May 28, 2025
Uses a TOML configuration file instead of command-line arguments for
webring configuration.

Closes #19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specifying -m in the file given by -f still throws an error

3 participants