-
Notifications
You must be signed in to change notification settings - Fork 201
add type hints to base.py
#1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Dr-Blank
wants to merge
14
commits into
pushingkarmaorg:typehints
Choose a base branch
from
Dr-Blank:code/typehints
base: typehints
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3425590
add type hints
Dr-Blank dfe293b
Remove unnecessary inheritance from Playlist
Dr-Blank 495c394
Remove unnecessary inheritance from Photo class.
Dr-Blank 88137bf
Fix issue with casting None values in utils.py
Dr-Blank 49c6dd0
Cleanup
Dr-Blank 29a93ea
More Code refctoring with typehints
Dr-Blank d30c1a3
Add datetime module and update function signatures
Dr-Blank 1231a9c
Implement requested changes
Dr-Blank d940c27
document reason for multiple overloads
Dr-Blank 90db72c
apply requested changes regarding formatting and code refactoring
Dr-Blank dfbc682
Sort imports
Dr-Blank d4fc723
apply suggestions
Dr-Blank 39394aa
Merge branch 'typehints' into code/typehints
Dr-Blank d6754c0
revert import statements as suggested
Dr-Blank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.