-
Notifications
You must be signed in to change notification settings - Fork 34
Improve password generator #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Functional everything is fine. TODO:
|
1d378af
to
64d1496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking quite nice.
However, I don't think the interface makes a lot of sense at this point.
Currently I would argue 95% of the time a user doesn't create a password in Cryptopus but rather saves an already existing password.
Therefore, the use case of going to an encryptable which already has a password and randomly generating a new one that then automatically overwrites the old one doesn't really exist in my opinion and is rather confusing.
Maybe a easy solution would be to not automatically overwrite the existing password but rather have a button that says "create new secure password" instead of always overwriting when using the slider or checking the symbol box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6808b8f
to
7a6fb3f
Compare
00f352d
to
be6af01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice!
As discussed with @kcinay055679 a nice improvement would be to maybe not show the password generator when the field is already pre-filled. Work out what you think is a nice idea and let's discuss it :)
I added a accordion to the password generator witch is expanded on default and auto collapses after generating a new password. But the Accordeon generated by my code isnt the same as the one from the docs. I think the reason for that behavior is that we are currently using bootstrap 4.6. |
@kcinay055679 |
The requested arrow is default functionality according to the ember docs, but in our project the arrow is simpy not there. |
ecd3f3e
to
d610931
Compare
520ebe8
to
151e944
Compare
…d on load in update
34a25ee
to
07a87d2
Compare
No description provided.