-
Notifications
You must be signed in to change notification settings - Fork 5
Bug/1556 Next Quarter generation does not work #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
peggimann
merged 13 commits into
main
from
bug/1556-next-quarter-generation-does-not-work
Aug 15, 2025
Merged
Bug/1556 Next Quarter generation does not work #1597
peggimann
merged 13 commits into
main
from
bug/1556-next-quarter-generation-does-not-work
Aug 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
2 tasks
f9890e4 to
e72d777
Compare
peggimann
requested changes
Aug 14, 2025
Collaborator
peggimann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! I only found some nit picks i'd change.
backend/src/main/java/ch/puzzle/okr/service/business/QuarterBusinessService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/service/business/QuarterBusinessService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/service/business/QuarterBusinessService.java
Outdated
Show resolved
Hide resolved
2fb87b0 to
40c0d3f
Compare
peggimann
approved these changes
Aug 15, 2025
Collaborator
peggimann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Nice job :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.