Bug/ 1587 Connection Pooling for staging and demo und prod #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
MasterEvarior
previously requested changes
Aug 13, 2025
Collaborator
MasterEvarior
left a comment
MasterEvarior
left a comment
There was a problem hiding this comment.
This looks already very good and solves our connection pool problems. Good job! 💯
There are some minor things to improve and some stylistic choices to change but this should no done in no time.
backend/src/main/java/ch/puzzle/okr/multitenancy/SchemaMultiTenantConnectionProvider.java
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/multitenancy/HikariContextTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/multitenancy/HikariContextTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/multitenancy/HikariContextTest.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/multitenancy/HikariContext.java
Outdated
Show resolved
Hide resolved
…method solely exists for tests #1587
Miguel7373
force-pushed
the
bug/1587-limit-connection-pooling
branch
from
317b7ac to
d187548
Compare
peggimann
requested changes
Aug 15, 2025
Miguel7373
force-pushed
the
bug/1587-limit-connection-pooling
branch
from
0b5b671 to
11c2daa
Compare
peggimann
approved these changes
Aug 15, 2025
peggimann
dismissed
MasterEvarior’s stale review
The requested changes have been implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.