Skip to content

Feature/1661 calculation of smaller values does not work #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MasterEvarior merged 9 commits into from
Aug 27, 2025
Merged

Feature/1661 calculation of smaller values does not work #1662

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
21ef6df
fix(frontend): Refactor calculation of metric percentage to also work…
ManuelMoeri Aug 26, 2025
9d4f441
fix(frontend): Fix case of having same baseline and stretchgoal #1661
ManuelMoeri Aug 26, 2025
a5c3ff7
style(frontend): Fix styling of calc method #1661
ManuelMoeri Aug 26, 2025
06e1b91
refactor(frontend): Shorten method by resolving conversations #1661
ManuelMoeri Aug 26, 2025
9f9185c
test(cypress): Clarify existing test #1661
ManuelMoeri Aug 26, 2025
67bff9f
test(cypress): Remove unwanted .only #1661
ManuelMoeri Aug 26, 2025
2bbf37b
test(cypress): Add test for negative values and fix existing setup to…
ManuelMoeri Aug 27, 2025
f68cd79
test(cypress): Add back tests that got deleted and fix formatting #1661
ManuelMoeri Aug 27, 2025
6b6eb27
test(cypress): Add test for checking negative edge value #1661
ManuelMoeri Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 34 additions & 7 deletions frontend/src/app/shared/custom/scoring/scoring.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,19 +105,46 @@ export class ScoringComponent implements OnInit, AfterViewInit, OnChanges {
const keyResult = this.keyResult as KeyResultMetricMin;
const lastCheckIn = keyResult.lastCheckIn?.value!;

if (lastCheckIn < keyResult.commitValue) {
if (keyResult.baseline === keyResult.stretchGoal) {
if (lastCheckIn >= keyResult.baseline) {
this.stretched = true;
this.failPercent = 100;
this.commitPercent = 100;
this.targetPercent = 100;
} else {
this.stretched = false;
this.failPercent = 0;
this.commitPercent = 0;
this.targetPercent = 0;
}
return;
}

// Decide comparison direction based on goal orientation
const increasing = keyResult.baseline < keyResult.stretchGoal;
const cmp = (a: number, b: number) => {
return increasing ? a < b : a > b;
};

if (cmp(lastCheckIn, keyResult.commitValue)) {
this.stretched = false;
this.failPercent = (lastCheckIn - keyResult.baseline) / (keyResult.commitValue - keyResult.baseline) * 100;
} else if (lastCheckIn < keyResult.targetValue) {
this.failPercent =
(lastCheckIn - keyResult.baseline) /
(keyResult.commitValue - keyResult.baseline) * 100;
} else if (cmp(lastCheckIn, keyResult.targetValue)) {
this.stretched = false;
this.failPercent = 100;
this.commitPercent = (lastCheckIn - keyResult.commitValue) / (keyResult.targetValue - keyResult.commitValue) * 100;
} else if (lastCheckIn < keyResult.stretchGoal) {
this.commitPercent =
(lastCheckIn - keyResult.commitValue) /
(keyResult.targetValue - keyResult.commitValue) * 100;
} else if (cmp(lastCheckIn, keyResult.stretchGoal)) {
this.stretched = false;
this.failPercent = 100;
this.commitPercent = 100;
this.targetPercent = (lastCheckIn - keyResult.targetValue) / (keyResult.stretchGoal - keyResult.targetValue) * 100;
} else if (lastCheckIn >= keyResult.stretchGoal) {
this.targetPercent =
(lastCheckIn - keyResult.targetValue) /
(keyResult.stretchGoal - keyResult.targetValue) * 100;
} else {
this.stretched = true;
}
}
Expand Down
Loading