Skip to content

Bug/1679 cant edit keyresults of a duped objective #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peggimann merged 3 commits into from
Oct 22, 2025
Merged

Bug/1679 cant edit keyresults of a duped objective #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01806a9
fix: duped keyresults not editable #1679
nevio18324 Oct 9, 2025
dbd6e9a
fix: add a migration to fix keyresults without commit and/or target v…
nevio18324 Oct 9, 2025
c273260
fix: update table selection #1679
schiltpuzzle Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backend/src/main/java/ch/puzzle/okr/service/business/KeyResultBusinessService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ private KeyResult makeCopyOfKeyResultMetric(KeyResult keyResult, Objective dupli
.withUnit(((KeyResultMetric) keyResult).getUnit()) //
.withBaseline(((KeyResultMetric) keyResult).getBaseline()) //
.withStretchGoal(((KeyResultMetric) keyResult).getStretchGoal()) //
.withCommitValue(((KeyResultMetric) keyResult).getCommitValue()) //
.withTargetValue(((KeyResultMetric) keyResult).getTargetValue()) //
.build();
}

Expand Down
8 changes: 8 additions & 0 deletions backend/src/main/resources/db/migration/V3_6_4__calculate_commit_and_target_values.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
UPDATE key_result
SET
target_value = ROUND((baseline + (stretch_goal - baseline) * 0.7)::numeric, 2),
commit_value = ROUND((baseline + (stretch_goal - baseline) * 0.3)::numeric, 2)
WHERE baseline IS NOT NULL
AND stretch_goal IS NOT NULL
AND target_value is NULL
AND commit_value is NULL;
Loading