Bug/1486 OKR_Demo_DB resetted nicht richtig #1693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miguel7373
force-pushed
the
bug/1486-okr-demo-db-reset-not-working
branch
from
e714648 to
230ffae
Compare
1 task
peggimann
requested changes
Nov 3, 2025
Collaborator
peggimann
left a comment
peggimann
left a comment
There was a problem hiding this comment.
PR SUMMARY
Title : Bug/1486 OKR_Demo_DB resetted nicht richtig
Author : @Miguel7373
Assignees: None
Overall verdict:
🙂 Good PR! I quite liked your approach and overall structure, it’s clear you put effort into this. There are a few small areas that could use some refinement or cleanup, but overall it’s solid work and likely ready soon.
Comment counts by severity:
CRIT : 0
HIGH : 1
MED : 1
LOW : 2
NIT : 0
Subcategory counts:
CMPLX : 1
CG : 1
FMT : 2
All comments (total: 4):
- [med-cg]: this is against our coding guidelines, use
//as in the other lines or remove it everywhere but be consistent. - [high-cmplx]: code is too complex, cant we simply strip the schema prefix and only work on the tables? If i remember correctly then flyway will set the schema in a dynamic way accordingly.
- [low-fmt]: improve formatting, why did it change?
- [low-fmt]: improve formatting, why did it change?
(P.S. Nitpicks do not require any fixing :D)
backend/src/main/java/ch/puzzle/okr/multitenancy/FlywayMultitenantMigrationInitializer.java
Outdated
Show resolved
Hide resolved
backend/src/main/resources/db/data-migration-demo/afterMigrate__0_0_clear_data.sql
Outdated
Show resolved
Hide resolved
backend/src/main/resources/db/data-migration-demo/afterMigrate__0_1_initialData_pitc.sql
Show resolved
Hide resolved
backend/src/main/resources/db/data-migration-demo/afterMigrate__0_2_initialData_acme.sql
Show resolved
Hide resolved
peggimann
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.