Skip to content

Add the total amount of hours for visible timespan to order_plannings (63115) #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

svenwey
Copy link
Collaborator

@svenwey svenwey commented Feb 24, 2025

This change adds an additional column with the total amount of hours in the visible/selected timespan in order_plannings (per member & total). Slightly alters the styling to accommodate these changes.

@svenwey svenwey requested a review from Kagemaru February 24, 2025 14:36
@svenwey svenwey self-assigned this Feb 24, 2025
@svenwey svenwey requested review from daniel-illi and removed request for Kagemaru February 26, 2025 10:31
@daniel-illi daniel-illi changed the title [63115] add the total amount of hours for visible timespan to order_plannings [63115] add the total amount of hours for visible timespan to order_plannings (63115) Feb 26, 2025
@daniel-illi daniel-illi changed the title [63115] add the total amount of hours for visible timespan to order_plannings (63115) Add the total amount of hours for visible timespan to order_plannings (63115) Feb 26, 2025
@svenwey svenwey requested a review from kronn March 5, 2025 07:17
Copy link
Member

@kronn kronn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite unsurprisingly, I want to see tests, at least for the change to the domain-class. Bonus for controller-tests that check if some expected strings are where they are expected.

@svenwey svenwey requested a review from kronn March 17, 2025 09:54
@svenwey svenwey force-pushed the feature/63115-order_plannings_adjust_hours_to_timespan branch from 0ef2cf6 to 679e296 Compare March 20, 2025 08:11
@svenwey svenwey force-pushed the feature/63115-order_plannings_adjust_hours_to_timespan branch from cc7045a to 16622f8 Compare March 20, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants