-
Notifications
You must be signed in to change notification settings - Fork 19
Add the total amount of hours for visible timespan to order_plannings (63115) #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
svenwey
wants to merge
7
commits into
master
Choose a base branch
from
feature/63115-order_plannings_adjust_hours_to_timespan
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add the total amount of hours for visible timespan to order_plannings (63115) #232
svenwey
wants to merge
7
commits into
master
from
feature/63115-order_plannings_adjust_hours_to_timespan
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronn
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite unsurprisingly, I want to see tests, at least for the change to the domain-class. Bonus for controller-tests that check if some expected strings are where they are expected.
0ef2cf6
to
679e296
Compare
Co-authored-by: Matthias Viehweger <[email protected]>
…g to specify if we only want the hours for the active period, or for any time)
cc7045a
to
16622f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an additional column with the total amount of hours in the visible/selected timespan in order_plannings (per member & total). Slightly alters the styling to accommodate these changes.