Feature #835 Header and Banner rework using Puzzle Shell #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomTannenbaum
force-pushed
the
feature/835-header-and-banner-unsing-puzzle-shell
branch
2 times, most recently
from
c43bbd4 to
de8b008
Compare
RandomTannenbaum
force-pushed
the
feature/835-header-and-banner-unsing-puzzle-shell
branch
from
92a71db to
f965769
Compare
Robin481
requested changes
Apr 24, 2025
There was a problem hiding this comment.
A few small things:
- On smaller screens the language dropdown collides with the logo pretty quickly, I would assume the PuzzleShell has solutions to handle this more gracefully? (two rows or something)
- When making it even smaller all the buttons dissapear and our easter egg is suddenly a white square that appears. Both of these things shouldn't happen.
RandomTannenbaum
force-pushed
the
feature/835-header-and-banner-unsing-puzzle-shell
branch
2 times, most recently
from
1a4a11d to
d1a9302
Compare
RandomTannenbaum
force-pushed
the
feature/835-header-and-banner-unsing-puzzle-shell
branch
2 times, most recently
from
e53ce07 to
a445ac7
Compare
…bring back (admin) addition for admin names, fix all failing specs
…m over the my profile button to always display it
…urrent nav tab when navigating back with logo
…ure turbo has fully loaded the page before calculating the top value of the scroll to menu
RandomTannenbaum
force-pushed
the
feature/835-header-and-banner-unsing-puzzle-shell
branch
from
94c6d9d to
9128768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.