Minor touchups#1
Open
ebblake wants to merge 4 commits intopvachon:mainfrom
Open
Conversation
There is no need to check whether z is null when we know that z was just assigned to a non-NULL x->parent.
Checking the code is as simple as running the just-built test binary.
Rearrange some typedefs so that a user need only read the public wavltree.h rather than also needing to read the wavltree_priv.h in order to know how to integrate a tree into their code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found your implementation of a WAVL tree, and noticed a couple of things worth cleaning up while I was learning from it. The patches are progressively more involved; I'm okay if you decide patches later in the series are too much.