feat: FileFormat for VORTEX #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
commented
Mar 31, 2025
Author
There was a problem hiding this comment.
once we have a stable writer implementation we should remove this and instead generate the file at test time
fix: Propagate UnconvertibleExpression through OR
pvary
force-pushed
the
file_Format_api_without_base
branch
from
820cd3e to
0c35110
Compare
* fix: properly close native resources in Vortex scans * fix system closing * format, bump vortex dep * bump vortex to correct release * remove print
pvary
force-pushed
the
file_Format_api_without_base
branch
2 times, most recently
from
16265b6 to
a04dec0
Compare
pvary
force-pushed
the
file_Format_api_without_base
branch
3 times, most recently
from
f828c3c to
eb205c1
Compare
pvary
force-pushed
the
file_Format_api_without_base
branch
2 times, most recently
from
a7ce1cb to
40f91b4
Compare
pvary
force-pushed
the
file_Format_api_without_base
branch
from
df3d7c4 to
54ff177
Compare
pvary
force-pushed
the
file_Format_api_without_base
branch
14 times, most recently
from
454fa9c to
24ab0ba
Compare
pvary
force-pushed
the
file_Format_api_without_base
branch
4 times, most recently
from
c61b8ba to
5f91620
Compare
pvary
force-pushed
the
file_Format_api_without_base
branch
from
5f91620 to
c3babfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've consolidated the changes from #1, rebased onto the latest version of the FileFormat branch.
I have not resolved all of the comments from the old PR