This repository was archived by the owner on Aug 2, 2019. It is now read-only.
Should be able to render both annotations and form fields#146
Open
mrbastian wants to merge 1 commit intopvginkel:masterfrom
Open
Should be able to render both annotations and form fields#146mrbastian wants to merge 1 commit intopvginkel:masterfrom
mrbastian wants to merge 1 commit intopvginkel:masterfrom
Conversation
Annotations flag was being used to render form fields, but not annotations (pdf comments). Tried to avoid modifying existing method behaviors in order to not break any existing code, but added a new method that uses a separate bool to draw form fields and does not modify Annotations flag so that annotations can be included in render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotations flag was being used to render form fields, but not annotations (aka PDF comments).
I tried to avoid modifying existing method behaviors in order to not break any existing code, but added a new method/parameter that uses a separate bool to draw form fields and does not modify Annotations flag so that annotations can also be included in render.