User/kendzisah/fix manifest analyzer validation#5176
Merged
JudahGabriel merged 7 commits intoOct 23, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances PWABuilder's manifest validation by implementing comprehensive image validation for icons and screenshots. The changes address a critical gap where invalid manifests were passing validation and subsequently failing during packaging.
- Added new capability checks for validating icon and screenshot types match their actual file types
- Added new capability checks for validating declared sizes match actual image dimensions
- Enhanced existing icon type checking logic to validate both declared types and file extensions consistently
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ManifestAnalyzer.cs | Added new capability checks and improved icon type validation logic |
| ImageValidationService.cs | Added new validation methods for image types and dimensions using ImageSharp |
| PwaCapabilityId.cs | Added enum values for the new validation capabilities |
| PwaCapability.cs | Added capability definitions for the new validation checks |
JudahGabriel
requested changes
Oct 17, 2025
Contributor
Author
JudahGabriel
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #[issue number]
#5119
PR Type
Describe the current behavior?
Previous Behavior and Bug
The Problem: PWABuilder's manifest analysis was insufficient, allowing invalid manifests to pass validation and subsequently fail during packaging. Specifically:
Describe the new behavior?
The Solution: Implemented comprehensive image validation with multiple new capability checks:
PR Checklist
npm run testand ensure that all tests passAdditional Information