update lyrics library #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
went from - lyricwikia (not supported) to - lyriq (supported)
pwittchen
requested changes
Dec 3, 2025
Owner
pwittchen
left a comment
pwittchen
left a comment
There was a problem hiding this comment.
Thank you for the PR!
In general, it looks fine, but you forgot to remove lyricwikia dependency from the requirements.txt and add there new lyriq dependency. Moreover, you can also remove section related to lyricwikia from the README.md, because it will be no longer needed after this change. I'm also wondering if these logging import and instructions are needed here.
spotifycli/spotifycli.py
Outdated
| lyrics = lyriq.get_lyrics(title, artist) | ||
|
|
||
| if lyrics is None: | ||
| # Lyrics not found |
| import textwrap | ||
| import datetime | ||
| from subprocess import Popen, PIPE | ||
| import logging |
| import lyriq | ||
|
|
||
| import lyricwikia | ||
| logging.getLogger("lyriq.lyriq").setLevel(logging.CRITICAL) |
Contributor
Author
There was a problem hiding this comment.
Without it the lyriq library will print a 404 error when it does not found the song specified on it's database. So to make the logging more clean i added that call.
Contributor
Author
|
I have push the changes to the |
pwittchen
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
went from using
to