remove page widget surface on size request, not on size allocate#892
Draft
jchilds0 wants to merge 1 commit intopwmt:developfrom
Draft
remove page widget surface on size request, not on size allocate#892jchilds0 wants to merge 1 commit intopwmt:developfrom
jchilds0 wants to merge 1 commit intopwmt:developfrom
Conversation
ac00132 to
13fde91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document widget uses size allocate to position the page widgets, which conflicts with the previous use of size allocate to invalidate the surface cache.
This should resolve:
Transparency doesn't really work on my machine, and its fast enough that I didn't have lag scrolling so it would be good to have people that can reproduce those issue test.
zathura_page_widget_update_surfaceshould only be called from the render thread, is this also the case for where I've changedgtk_widget_set_size_requesttozathura_page_widget_set_size_request? If not, whats the correct way to queue this function to be called in the render thread at some point?