Skip to content

Comments

Fix broken documentation links in docstrings#1162

Merged
s3alfisc merged 5 commits intopy-econometrics:masterfrom
mdizadi:fix-doc-links
Feb 4, 2026
Merged

Fix broken documentation links in docstrings#1162
s3alfisc merged 5 commits intopy-econometrics:masterfrom
mdizadi:fix-doc-links

Conversation

@mdizadi
Copy link
Contributor

@mdizadi mdizadi commented Feb 3, 2026

Summary

  • Fix relative paths in docstring links (remove /reference/ prefix)
  • Remove broken FixestMulti links (doc page doesn't exist)
  • Fix typo in Feols link (missing closing bracket)
  • Replace Greek letter β with 'beta' for Windows encoding compatibility

Details

The docstrings in feols_.py, fepois_.py, and feiv_.py contained broken links that prevented the documentation from building correctly on
Windows (due to encoding issues with the β character) and had incorrect paths for cross-references.

Test plan

  • Verified pixi run -e docs docs-build completes without errors
  • Verified generated .qmd files contain correct relative links

mdizadi and others added 2 commits February 3, 2026 13:54
- Fix relative paths in docstring links (remove /reference/ prefix)
- Remove broken FixestMulti links (doc page doesn't exist)
- Fix typo in Feols link (missing closing bracket)
- Replace Greek letter β with 'beta' for Windows encoding compatibility

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@s3alfisc
Copy link
Member

s3alfisc commented Feb 4, 2026

Verified generated .qmd files contain correct relative links

Hm when I built this locally, for some reason the links don't work / are not there 🤔

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
core-tests 74.94% <ø> (ø)
tests-extended ?
tests-vs-r 17.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/estimation/api/feglm.py 89.65% <ø> (ø)
pyfixest/estimation/api/feols.py 100.00% <ø> (ø)
pyfixest/estimation/api/fepois.py 96.00% <ø> (ø)
pyfixest/estimation/api/quantreg.py 82.60% <ø> (ø)
pyfixest/estimation/feiv_.py 87.27% <ø> (ø)
pyfixest/estimation/feols_.py 86.86% <ø> (-4.57%) ⬇️
pyfixest/estimation/fepois_.py 90.94% <ø> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@s3alfisc s3alfisc merged commit 2a2ba0e into py-econometrics:master Feb 4, 2026
9 checks passed
@s3alfisc
Copy link
Member

s3alfisc commented Feb 4, 2026

@all-contributors please add @mdizadi for code

@allcontributors
Copy link
Contributor

@s3alfisc

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@s3alfisc
Copy link
Member

s3alfisc commented Feb 4, 2026

@all-contributors please add @mdizadi for docs

@allcontributors
Copy link
Contributor

@s3alfisc

I've put up a pull request to add @mdizadi! 🎉

@s3alfisc
Copy link
Member

s3alfisc commented Feb 4, 2026

@all-contributors please add @mdizadi for docs

@allcontributors
Copy link
Contributor

@s3alfisc

@mdizadi already contributed before to doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants