-
Notifications
You must be signed in to change notification settings - Fork 51
Create a minimal environment with core dependencies #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 5 commits
fee6306
2fcd4f2
371a0fe
071c16a
bddad7b
717d08b
bc357b1
c086b45
e6db76d
e8eea29
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,15 @@ | |
import narwhals as nw | ||
import numpy as np | ||
import pandas as pd | ||
from tqdm import tqdm | ||
|
||
try: | ||
from tqdm import tqdm | ||
except ImportError: | ||
|
||
def tqdm(iterable, *args, **kwargs): | ||
"Define a dummy tqdm function." | ||
return iterable | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is being repeated a lot ... why don't we let tqdm be a core dep? It seems very lightweight There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same with I am more or less gravitating towards having a default / core env that includes joblib, tqdm, GT etc that users install with |
||
|
||
|
||
from pyfixest.estimation.feols_ import Feols, PredictionErrorOptions, PredictionType | ||
from pyfixest.estimation.FormulaParser import FixestFormula | ||
|
Uh oh!
There was an error while loading. Please reload this page.