feat(fepois): Use dynamic demeaning selection based on backend setting #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #852 by updating the
fepois
implementation to correctly utilize the specified demeaning backend. Previously, the code was hardcoded to use the Numba backend even when users specified an alternative (e.g., JAX).Key changes:
_set_demeaner_backend
and the associated logic that attempted to select a backend-specific demeaning function.Fepois
so that it directly callsdemean
, which internally manages the selection based on the provided_fe
andmu
parameters.ZX_resid
computation, ensuring the proper residualization when fixed effects are present.These modifications ensure that the demeaning backend is correctly utilized according to the user-specified
demeaner_backend
setting, providing greater flexibility and correctness when working with different backend implementations.Please review the changes and run the test suite to ensure that all functionality remains intact.
Closes #852.
Created with Repobird.ai 📦🐦