-
Notifications
You must be signed in to change notification settings - Fork 40
Introduce uv-dynamic-versioning #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ItsDrike
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work anymore now (this whole step should be removed):
mcstatus/.github/workflows/publish.yml
Lines 57 to 68 in 56b1dce
| - name: Make sure pyproject.toml version matches git version | |
| run: | | |
| git_version=$(git describe) | |
| git_version="${git_version:1}" # first character is always `v` | |
| pyproject_version=$(python -c "import tomllib; print(tomllib.load(open('pyproject.toml', 'rb'))['project']['version'])") | |
| if [ "$git_version" != "$pyproject_version" ]; then | |
| echo "The version specified in pyproject.toml ($pyproject_version) doesn't match the git version ($git_verson)" | |
| echo "You most likely forgot to update pyproject.toml when publishing the release tag" | |
| echo "You can fix this by updating the pyproject version and overwriting the git tag" | |
| exit 1 | |
| fi |
As asked in code review
ItsDrike
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The original reason we didn't use uv-dynamic-versioning after switching from Poetry was that it is not very popular. It still is, but it is quite annoying to do a bump PR each time we want to do a new release
See also #950 (look for uv-dynamic-versioning)