Skip to content

Conversation

@PerchunPak
Copy link
Member

The original reason we didn't use uv-dynamic-versioning after switching from Poetry was that it is not very popular. It still is, but it is quite annoying to do a bump PR each time we want to do a new release

See also #950 (look for uv-dynamic-versioning)

@PerchunPak PerchunPak requested a review from ItsDrike July 8, 2025 10:53
Copy link
Member

@ItsDrike ItsDrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

Copy link
Member

@ItsDrike ItsDrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work anymore now (this whole step should be removed):

- name: Make sure pyproject.toml version matches git version
run: |
git_version=$(git describe)
git_version="${git_version:1}" # first character is always `v`
pyproject_version=$(python -c "import tomllib; print(tomllib.load(open('pyproject.toml', 'rb'))['project']['version'])")
if [ "$git_version" != "$pyproject_version" ]; then
echo "The version specified in pyproject.toml ($pyproject_version) doesn't match the git version ($git_verson)"
echo "You most likely forgot to update pyproject.toml when publishing the release tag"
echo "You can fix this by updating the pyproject version and overwriting the git tag"
exit 1
fi

Copy link
Member

@ItsDrike ItsDrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ItsDrike ItsDrike merged commit ca3e547 into master Aug 7, 2025
11 checks passed
@ItsDrike ItsDrike deleted the introduce-uv-dynamic-versioning branch August 7, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants