CLI: use StatusResponse.as_dict() in JSON command#1102
CLI: use StatusResponse.as_dict() in JSON command#1102PerchunPak wants to merge 1 commit intomasterfrom
StatusResponse.as_dict() in JSON command#1102Conversation
| "Dinnerbone", | ||
| "Djinnibone", | ||
| "Steve", | ||
| ], |
There was a problem hiding this comment.
I don't really consider adding new fields to JSON as a breaking change, but we can postpone this PR until v13
There was a problem hiding this comment.
Hm, I'm not sure, I mean, it depends on how people are using this output, it could be breaking (if used with some kind of strict parsing into specific fields, where all have to be consumed), or it might not be (more likely).
The change of port from str to int might also be breaking.
I don't know how we should treat these kind of changes in the CLI. I think most people that rely on the kind of consumption where this would be breaking are likely using mcstatus as a library, rather than calling it via CLI, and generally, I think most people that are using it as CLI are doing so from simple bash scripts where these changes very likely wouldn't be braking, so I don't think it'd be particularly wrong to release this without a braking change. Though I also wouldn't mind postponing until the next major release.
There was a problem hiding this comment.
I'd like to postpone it after all, this is purely an internal QOL change
Update tests with new fields Remove unused import
88d7a49 to
170cca9
Compare
No description provided.