Skip to content

Conversation

@picvet
Copy link

@picvet picvet commented Jan 9, 2026

Added correct type for the color_space to be ArrayObject

For the test file test_xobject_image_helpers, all type hinting errors have been resolved

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.35%. Comparing base (10df9c7) to head (97645b3).

Files with missing lines Patch % Lines
pypdf/_xobj_image_helpers.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3595   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          55       55           
  Lines        9815     9817    +2     
  Branches     1791     1791           
=======================================
+ Hits         9555     9557    +2     
  Misses        153      153           
  Partials      107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefan6419846
Copy link
Collaborator

Thanks for the PR. Could you please have a look at the failing tests? Additionally, please keep the changes to the minimum - it seems to contain unrelated changes regarding the formatting and some strange ones regarding the tests.

Out of interest: Is there any actual error you observed or a related issue which lead to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants