Add scoring parameter to drlearner #1000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Daiha <[email protected]>
gdaiha
force-pushed
the
gdaiha/fix-dr-scoring
branch
from
ff617c4 to
243e8a0
Compare
|
Two tests failed with the same problem: "No module named '_posixsubprocess'". I sincerely think that changes here does not affect this module. How could we solve it? @kbattocchi |
|
Yes, the failure is unrelated to your changes, it looks like the build runners upgraded to Python 3.13.7 and we're hitting python/cpython#138031. I'll see what I can do to address it. |
|
I'm going to add the adjustments needed in _drlearner.py to make scoring parameter work, very similar to what've been done in DML |
Signed-off-by: Gabriel Daiha <[email protected]>
gdaiha
force-pushed
the
gdaiha/fix-dr-scoring
branch
from
1b113b9 to
2be4716
Compare
…core function Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
gdaiha
force-pushed
the
gdaiha/fix-dr-scoring
branch
from
2be4716 to
c75f649
Compare
gdaiha
changed the title
gdaiha
force-pushed
the
gdaiha/fix-dr-scoring
branch
from
ecea501 to
b70ca08
Compare
…core function Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
gdaiha
force-pushed
the
gdaiha/fix-dr-scoring
branch
from
b70ca08 to
92406d3
Compare
Signed-off-by: Gabriel Daiha <[email protected]>
…ha/fix-dr-scoring
gdaiha
changed the title
|
@kbattocchi , I ended the implementations here. Ready to review. The tests that are failing does not have any relationship with this new feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scoring parameter to drlearner, to allow score other metrics than MSE in Doubly Robust models