Add support for sample_weights in DRTester #1005
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
|
I'm going to implement tests to this new feature |
Signed-off-by: Gabriel Daiha <[email protected]>
… numpy>1.22 Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
…ithub.com/gdaiha/EconML into gdaiha/add-sample-weights-drtester-signed
Signed-off-by: Gabriel Daiha <[email protected]>
…ue in two groups Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
…by minimum value Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
|
pr is ready to review. tests implemented. |
Signed-off-by: Gabriel Daiha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve issue #1004 , this PR adds support for sample_weights in DRTester class.
It implements it in fit_nuisances and in each evaluation (calibration, uplift and blp).