Skip to content

Update supported dependency versions #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kbattocchi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update supported dependency versions #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions econml/dowhy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ class DoWhyWrapper:

def __init__(self, cate_estimator):
from packaging.version import parse
if parse(dowhy.__version__) >= parse('0.13'):
warnings.warn("econml has not been tested with dowhy versions >= 0.13")
if parse(dowhy.__version__) >= parse('0.15'):
warnings.warn("econml has not been tested with dowhy versions >= 0.15")
self._cate_estimator = cate_estimator

def _get_params(self):
Expand Down
4 changes: 2 additions & 2 deletions econml/sklearn_extensions/linear_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,13 +1247,13 @@ def score(self, X, y, sample_weight=None):
return self.model.score(X, y, sample_weight)

def __getattr__(self, key):
if key in self._known_params:
if key in self._known_params or key == '__sklearn_tags__':
return getattr(self.model, key)
else:
raise AttributeError("No attribute " + key)

def __setattr__(self, key, value):
if key in self._known_params:
if key in self._known_params or key == '__sklearn_tags__':
setattr(self.model, key, value)
else:
super().__setattr__(key, value)
Expand Down
10 changes: 5 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ classifiers = [
dependencies = [
"numpy",
"scipy > 1.4.0",
"scikit-learn >= 1.0, < 1.7",
"scikit-learn >= 1.0, < 1.8",
"sparse",
"joblib >= 0.13.0",
"statsmodels >= 0.10",
"pandas > 1.0",
"shap >= 0.38.1, < 0.49.0",
"shap >= 0.38.1, < 0.51",
"lightgbm",
"packaging"
]
Expand All @@ -49,7 +49,7 @@ plt = [
]
dowhy = [
# when updating this, also update the version check in dowhy.py
"dowhy < 0.13"
"dowhy >= 0.13, < 0.15"
]
ray = [
"ray > 2.2.0"
Expand All @@ -60,15 +60,15 @@ all = [
"azure-cli",
"graphviz",
"matplotlib",
"dowhy < 0.13",
"dowhy >= 0.13, < 0.15",
"ray > 2.2.0"
]

[build-system]
requires = [
"setuptools",
"wheel",
"numpy>=2,<3",
"numpy >=2, <3",
"scipy",
"cython"
]
Expand Down
Loading