Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update poetry and doc workflow #1302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update poetry and doc workflow #1302

wants to merge 1 commit into from

Conversation

bloebp
Copy link
Member

@bloebp bloebp commented Mar 14, 2025

Trying to update poetry and doc workflow.

@bloebp bloebp requested a review from emrekiciman March 14, 2025 23:14
Signed-off-by: Patrick Bloebaum <[email protected]>
@bloebp
Copy link
Member Author

bloebp commented Mar 15, 2025

@amit-sharma
The build fails due to https://github.com/py-why/dowhy/actions/runs/13867018046/job/38808031740?pr=1302#step:11:660

Any chance we can reduce some dependencies (e.g., is there an alternative way to asses the overlap without using cvxpy)?

@amit-sharma
Copy link
Member

amit-sharma commented Mar 15, 2025

the dependency is used for convex optimization, may be difficult to remove.
I checked that ecos package is actually installed. But two versions of cvxpy are installed according to poetry.lock. The problem might be that we are including cvxpy as a conditional install: a different version based on whether python 3.9+ is installed or not.
See pyproject file. Maybe we can try to avoid this conditional import, just like you were able to do with pytorch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants